vmware: do not check secondary storage and attach ISO when start a system vm#13031
Draft
weizhouapache wants to merge 1 commit intoapache:4.22from
Draft
vmware: do not check secondary storage and attach ISO when start a system vm#13031weizhouapache wants to merge 1 commit intoapache:4.22from
weizhouapache wants to merge 1 commit intoapache:4.22from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13031 +/- ##
=============================================
- Coverage 17.61% 3.69% -13.92%
=============================================
Files 5921 448 -5473
Lines 532392 38101 -494291
Branches 65109 7059 -58050
=============================================
- Hits 93788 1409 -92379
+ Misses 428015 36505 -391510
+ Partials 10589 187 -10402
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes unnecessary check on secondary storage and ISO attachment when start a system vm on vmware.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?